Remove pytest-runner from build-system.requires #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pytest-runner` package has been deprecated upstream for some time, and the project is now archived: https://github.com/pytest-dev/pytest-runner/tree/v6.0.1?tab=readme-ov-file#deprecation-notice Furthermore, the "setup.py test" command was removed in setuptools 72: https://github.com/pypa/setuptools/blob/v75.8.0/NEWS.rst#v7200 This does not affect running the tests with pytest.
|
Thanks for the contribution! Before we can merge this, we need @musicinmybrain to sign the Salesforce Inc. Contributor License Agreement. |
|
I signed the CLA, although things seem a bit crashy (for example, https://cla.salesforce.com/status/slackapi/python-slack-sdk/pull/1659 produces an error), so who knows if the automation will ever figure that out. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1659 +/- ##
=======================================
Coverage 85.36% 85.36%
=======================================
Files 113 113
Lines 12802 12802
=======================================
Hits 10928 10928
Misses 1874 1874 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pytest-runnerpackage has been deprecated upstream for some time, and the project is now archived:https://github.com/pytest-dev/pytest-runner/tree/v6.0.1?tab=readme-ov-file#deprecation-notice
Furthermore, the "setup.py test" command was removed in setuptools 72: https://github.com/pypa/setuptools/blob/v75.8.0/NEWS.rst#v7200
This does not affect running the tests with pytest.
Summary
Removes the dependency on the deprecated
pytest-runnerpackage, which – since this project does not use the deprecated/removedsetup.py testfor running tests and does not use the deprecatedtests_requirefor expressing test dependencies – was no longer doing anything useful anyway.Testing
Run the tests, in any of the usual ways, and observe that everything still works.
Consult the linked deprecation notice for
pytest-runner.Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.